Array type checking fixes
#317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majosm
commented
Jun 4, 2025
Collaborator
Author
|
@inducer I'm not sure what to do about this pyopencl stub file thing that pyright wants. Should that be ignored for now? |
Owner
Oddly enough, pyopencl is quite close to picking up types: inducer/pyopencl#833. |
majosm
force-pushed
the
array-type-checking-fixes
branch
2 times, most recently
from
6b0d338 to
5f41e0f
Compare
inducer
reviewed
Jun 14, 2025
majosm
force-pushed
the
array-type-checking-fixes
branch
from
5f41e0f to
bffcda0
Compare
Owner
|
Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes to help make the
Arrayprotocol compatible with pytato'sArray. Depends on inducer/pytato#606.